-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-48011: XAPI Support anti-affinity feature check #5631
CP-48011: XAPI Support anti-affinity feature check #5631
Conversation
bf9facd
to
ae33ef1
Compare
ocaml/xapi/xapi_vm_group_helpers.ml
Outdated
let host_uuid = Db.Host.get_uuid ~__context ~self:host in | ||
let body = | ||
String.concat "" | ||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably not easy to add: but how rules are violated would be useful to know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The breaching for anti-affinity rule can be accessed in this PR: #5605
ae33ef1
to
5b18928
Compare
The new commit looks fine in principle. But we need to get the other PR done first and then rebase this PR. |
6545480
to
cf11976
Compare
Check feature flag in these places: 1. VM start. 2. Host evacuation. When this PR is raised, the host evacuation PR is still in review. So this PR doesn't include the checking for host evacuation. It will be included in another new PR. 3. Create VM group. 4. VM.set_groups. Adding VMs to a group and removing VMs from a group are all forbidden. If customers need to remove VMs from a group, just destroy the group. 5. Send VM anti-affinity alerts. Also, based on our discussion, the name of feature is changed from `VM_anti_affinity` to `VM_group`. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
cf11976
to
606423e
Compare
6529c0b
into
xapi-project:feature/vm-anti-affinity
Check feature flag in these places:
still in review. So this PR doesn't include the checking for host
evacuation. It will be included in another new PR.
are all forbidden. If customers need to remove VMs from a group,
just destroy the group.
Also, based on our discussion, the name of feature is changed from
VM_anti_affinity
toVM_group
.