-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CVM and relevant test cases #5655
Remove CVM and relevant test cases #5655
Conversation
CVM had been supported but not since long time ago. This commit is to clean up the remanent code and test cases. Signed-off-by: Ming Lu <ming.lu@cloud.com>
3a80f2a
to
5036409
Compare
@@ -87,7 +87,6 @@ let test_xapi_restart_inner () = | |||
Xapi_xenops.start ~__context ~self:vm5 false false ; | |||
Xapi_xenops.start ~__context ~self:vm6 false false ; | |||
Xapi_xenops.start ~__context ~self:vm7 false false ; | |||
(* vm6 is a ntnx CVM *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are removing CVM related logic as CVM is not supported now, is the test for vm6 still needed?
ocaml/tests/test_xapi_xenops.ml
Outdated
@@ -87,7 +87,6 @@ let test_xapi_restart_inner () = | |||
Xapi_xenops.start ~__context ~self:vm5 false false ; | |||
Xapi_xenops.start ~__context ~self:vm6 false false ; | |||
Xapi_xenops.start ~__context ~self:vm7 false false ; | |||
(* vm6 is a ntnx CVM *) | |||
Db.VM.set_is_control_domain ~__context ~self:vm6 ~value:true ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this line be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comment is not correct. The vm6
is actually not a CVM. Its name doesn't end with "-CVM".
Signed-off-by: Ming Lu <ming.lu@cloud.com>
Signed-off-by: Ming Lu <ming.lu@cloud.com>
Signed-off-by: Ming Lu <ming.lu@cloud.com>
CVM had been supported but not since long time ago.
This commit is to clean up the remanent code and test cases.