Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-48011: Xapi Support anti-affinity feature flag #5666

Merged
merged 1 commit into from
Jun 3, 2024
Merged

CP-48011: Xapi Support anti-affinity feature flag #5666

merged 1 commit into from
Jun 3, 2024

Conversation

BengangY
Copy link
Contributor

@BengangY BengangY commented Jun 3, 2024

  1. Rename feature flag VM_group to VM_groups.
  2. Add feature check in host evacuation

@BengangY
CP-48011: Xapi Support anti-affinity feature flag
8a9074f 
1. Rename feature flag VM_group to VM_groups.
2. Add feature check in host evacuation

Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
@gangj
Copy link
Contributor

gangj commented Jun 3, 2024

@BengangY Do we have UT for Features.VM_groups for other scenario like "VM start"? Add a parameter for compute_anti_aff_evac_plan like anti_aff_enabled can make it UT-able for compute_anti_aff_evac_plan (There are unit test cases for compute_anti_aff_evac_plan now).

@BengangY BengangY marked this pull request as ready for review June 3, 2024 10:29
@robhoes robhoes merged commit de580e5 into xapi-project:feature/vm-anti-affinity Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robhoes robhoes robhoes approved these changes

@gangj gangj gangj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BengangY @gangj @robhoes