Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo docs: Add dark mode support, theme variant selector and print #5703

Conversation

bernhardkaindl
Copy link
Collaborator

Remark:
Same #5702 (closed), but for master (because it had nothing to do with py3 and had an unrelated CI failure)

Thanks everyone for all the reviews and tips for #5698!

In #5698 (comment) there was some doubt (or maybe just misunderstanding) on the second commit of #5698 for publishing a preview of the docs on the clone repo's GitHub pages (will only be published if the GitHub pages are configured to be published from GitHub actions, not from the gh-pages branch).

In any case, the two commits of #5698 are no dependent on each other, so this submits only the first commits of it for review.

Thanks for the hints on fixing or working around these issues!

I cannot incorporate them in this PR at the moment because I'll be on PTO until Monday.

But if you merge (or otherwise approve - does not have to be now - the) enabling the selection of the theme variants (independent on if you include the auto switch to dark mode by default using the "auto" variant), we can make the fixes for those locations over time.

You can also close this PR if you like to have either the dark mode or print view issues fixed before enabling the automatic dark mode, all of that is fine of course.

I only opened these PRs because I saw the possibility to make these features of the theme available.

I'll (tentatively) close #5698 and to focus on this PR for now.

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl merged commit 7348b74 into xapi-project:master Jun 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants