-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cluster-stack-version
show up in the CLI
#5711
Make cluster-stack-version
show up in the CLI
#5711
Conversation
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have
[root@lcy2-dt110 ~]# xe host-param-get param-name=software-version uuid=c1517689-49cd-4088-9f20-149678beb526
product_version: 8.4.0; product_version_text: 8; product_version_text_short: 8; platform_name: XCP; platform_version: 3.4.0; product_brand: XenServer; build_number: stream; git_id: 0.41.g036d8331c; hostname: localhost; date: 20240606T14:09:08Z; dbv: 2024.0229; is_preview_release: false; xapi: 24.15; xapi_build: 24.15.0.41.g036d8331c; xen: 4.17.4-4; linux: 4.19.0+1; xencenter_min: 2.21; xencenter_max: 2.21; network_backend: openvswitch; db_schema: 5.778
Ok, what does this have to do with my PR? Or are you just pointing out something interesting? |
If we are looking for a way to report versions, extending |
Ah, that's because it is not just for reporting versions, it also controls which version of the cluster-stack (corosync) will be started, and used internally in all sorts of places. I think extending the That said, using |
We could create a ticket to report the version there in addition? Maybe for @last-genius |
This makes
cluster-stack-version
show up as a field of the cluster object in cli