CP-50050 track CBT status for SMAPIv3 SRs #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdn32
commented
Jul 1, 2024
rdn32
commented
- Use cbt_enabled flag from plugin responses, to allow that a snapshot of a CBT-enabled VDI will itself be CBT-enabled.
- As part of vdi-data-destroy, record the VDI type as a custom key, so that on a subsequent sr-scan it still shows up as a metadata-only snapshot.
psafont
reviewed
Jul 1, 2024
- Use cbt_enabled flag from plugin responses, to allow that a snapshot of a CBT-enabled VDI will itself be CBT-enabled. - As part of vdi-data-destroy, record the VDI type as a custom key, so that on a subsequent sr-scan it still shows up as a metadata-only snapshot. Signed-off-by: Robin Newton <robin.newton@cloud.com>
rdn32
force-pushed
the
private/rnewton/CP-50050
branch
from
96a16cf
to
f5e35fd
Compare
contificate
approved these changes
Jul 1, 2024
Vincent-lau
approved these changes
Jul 1, 2024
| ) | ||
| in | ||
| let* () = set ~dbg ~sr ~vdi ~key:_vdi_type_key ~value:"cbt_metadata" in | ||
| Deferred.Result.return response |
There was a problem hiding this comment.
this response var is always going to be a unit, isn't it? We could just return unit here
There was a problem hiding this comment.
It could be changed to
let* () = return_volume_rpc (...) in
set ~dbg ... ~value"cbt_metadata"But the way it is right now is fine as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.