CP-50193: Update new fingerprint fields on DB upgrade #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Jul 5, 2024
psafont
reviewed
Jul 5, 2024
snwoods
force-pushed
the
private/stevenwo/CP-50193
branch
from
274ab83
to
b103a8c
Compare
snwoods
commented
Jul 8, 2024
psafont
reviewed
Jul 9, 2024
psafont
reviewed
Jul 9, 2024
snwoods
force-pushed
the
private/stevenwo/CP-50193
branch
from
b103a8c
to
8df3ef6
Compare
The new fingerprint_sha256 and fingerprint_sha1 fields will be empty when upgrading from a version without the fields. This commit checks for this and fills them in, stopping the certificate from being needlessly reinstalled. Signed-off-by: Steven Woods <steven.woods@citrix.com>
snwoods
force-pushed
the
private/stevenwo/CP-50193
branch
from
8df3ef6
to
826e6d0
Compare
psafont
approved these changes
Jul 10, 2024
Yep, tested on both an rt-next pool and a pool which had the sha1 changes. In both occasions, the logs showed that the certificate was not reinstalled and in the former case it showed the new fingerprint fields were populated. It correctly sent both sha256 and sha1 when requested on HOST_IS_SLAVE error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new fingerprint_sha256 and fingerprint_sha1 fields will be empty when upgrading from a version without the fields. This commit checks for this and fills them in, stopping the certificate from being needlessly reinstalled.