Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-CDN updates bug fix #5904

Conversation

BengangY
Copy link
Contributor

@BengangY BengangY commented Aug 2, 2024

Fix some non-CDN bugs/comments:

  1. Change the max total bundle files size limit to 1G.
  2. Change HTTP error code for the following error to 400:
    bundle_repo_not_enabled.
    no_repository_enabled.
    multiple_update_repositories_enabled.
  3. Add a new API error for bundle syncing failure "Syncing with bundle repository failed."

@BengangY BengangY marked this pull request as ready for review August 2, 2024 09:18
@BengangY BengangY changed the title non-CDN bug fix Non-CDN updates bug fix Aug 2, 2024
@BengangY BengangY force-pushed the private/bengangy/non-cdn-bug-fix branch from 35da761 to e1b2712 Compare August 2, 2024 09:46
Copy link
Contributor

@gangj gangj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to update the commit message of the 2nd commit to something like "Add a new error code ..."

@BengangY BengangY force-pushed the private/bengangy/non-cdn-bug-fix branch from e1b2712 to e6ec610 Compare August 2, 2024 11:01
@BengangY
Copy link
Contributor Author

BengangY commented Aug 2, 2024

Would be better to update the commit message of the 2nd commit to something like "Add a new error code ..."

Updated.

@BengangY BengangY force-pushed the private/bengangy/non-cdn-bug-fix branch from e6ec610 to 94609e6 Compare August 5, 2024 11:13
1. Change the max total bundle files size limit to 1G.
2. Change HTTP error code for the following error to 400:
  1) bundle_repo_not_enabled.
  2) no_repository_enabled.
  3) multiple_update_repositories_enabled.

Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
Add a new API error for bundle syncing failure:
Syncing with bundle repository failed.

Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
@BengangY BengangY force-pushed the private/bengangy/non-cdn-bug-fix branch from 94609e6 to 65e35bc Compare August 5, 2024 11:17
@minglumlu minglumlu merged commit 5fa500c into xapi-project:feature/non-cdn-update Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants