Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-392685:/tmp is mounted with type tmpfs which cause the files to be cleaned after host reboot in XS rawhide. #5933

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

ashwin9390
Copy link
Contributor

CA-392685 :/tmp is mounted with type tmpfs which cause the files to be cleaned after host reboot in XS rawhide

Fix contains:

  • Replace /tmp/network-reset with /var/tmp/network-reset to persist tmp file after reboot
  • Modified xapi_globs.ml to include this change.

XenRT test -Completed

Test Results:

Test id :4073591(XS9)-Pass
Test id :4068756(XS8)-Pass

Signed-off-by: Ashwinh ashwin.h@cloud.com

@liulinC @psafont @rosslagerwall @bernhardkaindl

…persist tmp file after reboot

- Modified xapi_globs.ml to include this change.

Signed-off-by: Ashwinh <ashwin.h@cloud.com>
@ashwin9390 ashwin9390 changed the title CA-392685: Replace /tmp/network-reset with /var/tmp/network-reset to persist tmp file after reboot CA-392685: :/tmp is mounted with type tmpfs which cause the files to be cleaned after host reboot in XS rawhide. Aug 13, 2024
@ashwin9390 ashwin9390 changed the title CA-392685: :/tmp is mounted with type tmpfs which cause the files to be cleaned after host reboot in XS rawhide. CA-392685:/tmp is mounted with type tmpfs which cause the files to be cleaned after host reboot in XS rawhide. Aug 13, 2024
@liulinC liulinC merged commit fc89ed5 into xapi-project:master Aug 14, 2024
15 checks passed
@stormi
Copy link
Contributor

stormi commented Aug 14, 2024

IMO the initial PR title (which is still that of the merged commit) was better than the current one, because it described what changes, not the cause of the problem.

However it would have been nice to mention the cause in the body of the commit message itself, so that the WHY of the change is visible in the commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants