CA-91480: Catch exception if blob doesn't exist on vm_destroy #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 6, 2012 18:17
Xapi_vm_helpers.destroy would fail if a VM had a reference to a non-existant blob, which would happen when the VM had been imported. This would prevent the rest of the function from running, leaving ghost objects in the database after an import was cancelled. Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
Xapi_vm_helpers.destroy would fail if a VM had a reference to a non-existant blob, which would happen when the VM had been imported. This would prevent the rest of the function from running, leaving ghost objects in the database after an import was cancelled. Signed-off-by: Mike McClurg <mike.mcclurg@citrix.com>
mcclurmc/xen-api@fc9a4bf ⇒ dbd1565: Build succeeded. Can merge pull request. |
mcclurmc/xen-api@fc9a4bf ⇒ 2c0fbe1: Build succeeded. Can merge pull request. |
|
@xen-git Approved |
xen-git
pushed a commit
that referenced
this pull request
Nov 9, 2012
mcclurmc/xen-api@fc9a4bf ⇒ 4474f90: Build succeeded. Pull request merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was meant to fix CA-91480, but it turns out that this was a different issue. This issue is that vm_destroy doesn't catch an exception if it tries to destroy a VM which has a blob which also doesn't exist on the server, which could happen in a vm_import.
This is the first bug we've found that we've also included a regression unit test for, which is significant. Otherwise, this is an unlikely bug to encounter and fairly trivial to solve.