Fix normalize() to actually modify the gradients

Picked up thanks to a clang warning.
xapian · Jun 30, 2022 · 313eca9 · 313eca9
1 parent e8ee181
commit 313eca9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/xapian-letor/ranker/listnet_ranker.cc b/xapian-letor/ranker/listnet_ranker.cc
@@ -121,7 +121,7 @@ update_parameters(vector<double> &new_parameters, const vector<double> &gradient
 
 static void
 normalize(vector<double>& gradient, size_t size) {
-    for (auto item : gradient) {
+    for (auto& item : gradient) {
 	item /= size;
     }
 }