Code for query expansion. #24
Conversation
| * the name of the scheme to be used. If no scheme is specified, | ||
| * "bo1" is used. | ||
| */ | ||
| void set_expansion_scheme(const std::string eweightname_ = "bo1"); |
There was a problem hiding this comment.
Either this should match the docstring or the docstring should match this.
There was a problem hiding this comment.
Please can you explain what this means ?
There was a problem hiding this comment.
@param eweight_ is not the name of the actual parameter.
| // so we use "<=" not "<" here. | ||
| /* Set up the EXpandweight by clearing the existing statistics and | ||
| collecting statistics for the new term. */ | ||
| (eweight.stats).clear_stats(); |
There was a problem hiding this comment.
the () look leftover from a previous iteration
| @@ -53,6 +53,8 @@ | |||
| using namespace std; | |||
|
|
|||
| using Xapian::Internal::ExpandWeight; | |||
| using Xapian::Internal::Bo1Eweight; | |||
| using Xapian::Internal::TradEweight; | |||
There was a problem hiding this comment.
The 'w' in 'weight' should really be capitalised in these class names (it's "trad. e. weight", not "trad eweight").
| * | ||
| * @param eweightname_ A three character string in lowercase | ||
| * specifying the name of the scheme to be used. | ||
| * The following schemes are currently availabe: |
| double expand_k; | ||
|
|
||
| public: | ||
| public: |
| double k, const ExpandDecider * edecider, double min_wt) const | ||
| { | ||
| LOGCALL(API, Xapian::ESet, "Xapian::Enquire::get_eset", | ||
| maxitems | rset | k | flags | edecider | min_wt); |
There was a problem hiding this comment.
Cool, that looks a suitable compatibility wrapper.
We don't bother wrapping LOGCALL lines - they aren't aimed at human readers (since they just duplicate information from the function prototype). Ideally they'd just get added/updated automatically, but nobody's written a script to automate that task yet.
There was a problem hiding this comment.
Oh okay, didnt know that. I am not undoing this change but will keep this in mind :)
There was a problem hiding this comment.
Please actually make the change.
| { | ||
| LOGCALL(MATCH, double, "ExpandWeight::get_weight", merger | term); | ||
| LOGCALL(MATCH, void, "ExpandWeight::collect_stats", merger | term); |
There was a problem hiding this comment.
LOGCALL_VOID() should be used in such cases - using void in the normal LOGCALL macro results in typedef void foo; when compiling with logging enabled, and some compilers don't like that.
|
Merged via SVN. |
No description provided.