Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for serialization, and a Python script for integration testing #38

Merged
merged 8 commits into from
Sep 27, 2017

Conversation

zanebeckwith
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 27, 2017

Codecov Report

Merging #38 into master will increase coverage by 4.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   77.41%   81.62%   +4.21%     
==========================================
  Files          22       31       +9     
  Lines        1014     1524     +510     
  Branches       65      140      +75     
==========================================
+ Hits          785     1244     +459     
+ Misses        210      172      -38     
- Partials       19      108      +89
Impacted Files Coverage Δ
test/group_public_key-tests.c 100% <100%> (ø)
test/credential-tests.c 100% <100%> (ø) ⬆️
test/member_keypair-tests.c 100% <100%> (ø) ⬆️
test/signature-tests.c 100% <100%> (ø)
test/ecp_BN254-tests.c 100% <100%> (ø) ⬆️
test/big_256_56-tests.c 100% <100%> (+6.02%) ⬆️
test/issuer_keypair-tests.c 100% <100%> (ø) ⬆️
test/ecp2_BN254-tests.c 100% <100%> (ø) ⬆️
examples/verify.c 42.85% <0%> (ø)
examples/issuer_respond_to_join_request.c 26% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0b3f5...1b53926. Read the comment docs.

@zanebeckwith zanebeckwith force-pushed the improve-test-coverage branch 2 times, most recently from e8ce9d4 to 63f5211 Compare September 27, 2017 20:03
That test was written, but never actually called.
Just runs through example-programs.
@zanebeckwith zanebeckwith changed the title Add tests for serialization, etc, to improve test coverage Add tests for serialization, and a Python script for integration testing Sep 27, 2017
@zanebeckwith
Copy link
Collaborator Author

Related to #33

But, this only tests our serialization code, and incorporates the example programs for integration tests.

We still need to take some time and improve our tests, to hit corner cases and failure modes.

@zanebeckwith zanebeckwith merged commit 6827f57 into xaptum:master Sep 27, 2017
@zanebeckwith zanebeckwith deleted the improve-test-coverage branch September 27, 2017 22:14
@zanebeckwith zanebeckwith mentioned this pull request Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants