-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing kwargs behaviour when opening datatree stored in zarr #328
Conversation
for more information, see https://pre-commit.ci
…nto dtree-kwargs merging into local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @aladinor !
Would it be easy to add a test that checks the .chunks
are as you expect them to be?
v int64 8B 1 | ||
|
||
Data in nodes at position '/a/b' do not match: | ||
|
||
Differing data variables: | ||
L w int64 5 | ||
R w int64 6""" | ||
L w int64 8B 5 | ||
R w int64 8B 6""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This difference is due to a newer version of xarray - v2024.2.0. Technically I guess we should pin to that version to match this change?
…ing datatree stored in zarr
for more information, see https://pre-commit.ci
Test looks great @aladinor - I think the error is just because dask is not installed in the test environment. |
Thanks @TomNicholas. Should we include it? do you think we can merge without passing the checks? |
Just try adding it to the |
…nto dtree-kwargs merging
kwargs
#327pre-commit run --all-files
api.rst
docs/source/whats-new.rst