fixing kwargs behaviour when opening datatree stored in zarr #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto dtree-kwargs merging into local
TomNicholas
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Thanks for this @aladinor !
Would it be easy to add a test that checks the .chunks are as you expect them to be?
Comment on lines
+111
to
+117
| v int64 8B 1 | ||
|
|
||
| Data in nodes at position '/a/b' do not match: | ||
|
|
||
| Differing data variables: | ||
| L w int64 5 | ||
| R w int64 6""" | ||
| L w int64 8B 5 | ||
| R w int64 8B 6""" |
There was a problem hiding this comment.
This difference is due to a newer version of xarray - v2024.2.0. Technically I guess we should pin to that version to match this change?
…ing datatree stored in zarr
for more information, see https://pre-commit.ci
|
Test looks great @aladinor - I think the error is just because dask is not installed in the test environment. |
|
Thanks @TomNicholas. Should we include it? do you think we can merge without passing the checks? |
|
Just try adding it to the |
…nto dtree-kwargs merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwargs#327pre-commit run --all-filesapi.rstdocs/source/whats-new.rst