Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a few typos #74

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Conversation

e-marshall
Copy link
Contributor

few things not included in this:

  • sst dataset link in computation notebook
  • in computation notebook it looks like the t90_fromt68() function is expected to return a np array to setup using apply_ufunc() in the next cell but it returns a xr.DataArray instead - not sure if intentional or not ?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@scottyhq
Copy link
Contributor

sst dataset link in computation notebook

It seems this might be an intermittent error, so let's leave for now (might need to change to https://psl.noaa.gov/thredds/dodsC/Datasets/noaa.ersst.v5/sst.mnmean.nc)...

in computation notebook it looks like the t90_fromt68()

Noted in #61. I think we should remove the gsw section here and discuss apply_ufunc under Intermediate...

Thanks @e-marshall seems there is a kernel naming issue (maybe from nb_conda_kernels...) but otherwise happy to merge this and address these other issues later

e-marshall and others added 2 commits June 15, 2022 15:59
Co-authored-by: Scott Henderson <scottyhq@gmail.com>
Co-authored-by: Scott Henderson <scottyhq@gmail.com>
@e-marshall e-marshall marked this pull request as ready for review June 15, 2022 22:02
@scottyhq scottyhq merged commit cdb4b6a into xarray-contrib:main Jun 15, 2022
@dcherian
Copy link
Contributor

Nice work Emma!

@e-marshall e-marshall deleted the fixing-typos-new branch June 16, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants