-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more index adapters #28
Conversation
Test against brute-force neighbor lookup.
+ ipython completions
Each index adapter is tested against brute-force nearest neighbor lookup for the whole matrix:
Not sure we need to apply the whole matrix each time, but this can be addressed later. |
Looks very good! Two things I noticed:
|
Good catch, your two points are addressed in the last commits. I also implemented attribute access for the index registry. It's convenient for easily accessing the index adapter docstrings, e.g.,
|
I have no idea on what is causing random crashes on ubuntu... |
Mmm looks like |
...until pys2index conda packages are fixed on ubuntu-latest.
I'm going to merge this and move on with the remaining items in #29. Thanks @willirath for having a look! |
TODO:
sklearn.neighbors.KDTree
adapterpys2index
)scipy.cKDTree
adapterMaybe in this PR or later (if relevant):
All dependencies are optional, adapters are not registered if their corresponding package is not installed.