Feat/#175 homebrew release #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Thanks for the contribution @sFritsch09 👍
I've made some suggestions.
- I'm going to create the
homebrew-pgrollrepository. [repo]
adding license-check Co-authored-by: Andrew Farries <andyrb@gmail.com>
|
Pleasure @andrew-farries, it's my first PR so far, appreciate your input! |
andrew-farries
requested changes
Oct 9, 2023
andrew-farries
requested changes
Oct 10, 2023
andrew-farries
requested changes
Oct 10, 2023
|
Hi @sFritsch09 , thank you very much for your contribution! We would love to send you some swag, could you reach out to me via email: philip@xata.io to coordinate? Cheers, Philip |
andrew-farries
force-pushed
the
feat/#175-homebrew-release
branch
from
4c88507
to
48e88be
Compare
andrew-farries
force-pushed
the
feat/#175-homebrew-release
branch
from
eba3ef3
to
a4026ba
Compare
andrew-farries
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
I've removed the remaining formatting changes from docs/README.md and updated the repo's settings.yaml file.
This looks good to go now 🚢
Thanks for your contribution @sFritsch09! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to edit the build pipeline because using the build steps for gorelease you need to have the Pro version: https://goreleaser.com/customization/builds/#import-pre-built-binaries
Anyway I kept the same binary structure as before and the pipeline is much shorter with goreleaser now.
✅ Added Homebrew with GoReleaser
✅ Edit build pipeline and tested workflow
In order to let GoRelease push the artefacts you need to add GITHUB_TOKEN secret:
The minimum permissions the GITHUB_TOKEN should have to run this are write:packages