-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#175 homebrew release #180
Feat/#175 homebrew release #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @sFritsch09 👍
I've made some suggestions.
- I'm going to create the
homebrew-pgroll
repository. [repo]
adding license-check Co-authored-by: Andrew Farries <andyrb@gmail.com>
Pleasure @andrew-farries, it's my first PR so far, appreciate your input! |
Hi @sFritsch09 , thank you very much for your contribution! We would love to send you some swag, could you reach out to me via email: philip@xata.io to coordinate? Cheers, Philip |
4c88507
to
48e88be
Compare
eba3ef3
to
a4026ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the remaining formatting changes from docs/README.md
and updated the repo's settings.yaml
file.
This looks good to go now 🚢
Thanks for your contribution @sFritsch09! ❤️
I needed to edit the build pipeline because using the build steps for gorelease you need to have the Pro version: https://goreleaser.com/customization/builds/#import-pre-built-binaries
Anyway I kept the same binary structure as before and the pipeline is much shorter with goreleaser now.
✅ Added Homebrew with GoReleaser
✅ Edit build pipeline and tested workflow
In order to let GoRelease push the artefacts you need to add GITHUB_TOKEN secret:
The minimum permissions the GITHUB_TOKEN should have to run this are write:packages