Make state initialization concurrency safe #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce duplication between the different With* helper functions.
andrew-farries
changed the title
eminano
approved these changes
Feb 23, 2024
exekias
reviewed
Feb 23, 2024
andrew-farries
force-pushed
the
advisory-lock-init
branch
from
2f64226
to
4cf0e6a
Compare
exekias
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
pgrollstate initialization concurrency safe by using Postgres advisory locking to ensure at most one connection can initialize at at time.See docs on Postgres advisory locking:
Closes #283