Improve locking around pgroll initialization #283
Assignees
Labels
bug
Something isn't working
Comments
andrew-farries
added a commit
that referenced
this issue
Feb 26, 2024
Make `pgroll` state initialization concurrency safe by using Postgres advisory locking to ensure at most one connection can initialize at at time. See docs on Postgres advisory locking: * https://www.postgresql.org/docs/current/functions-admin.html#FUNCTIONS-ADVISORY-LOCKS * https://www.postgresql.org/docs/current/explicit-locking.html#ADVISORY-LOCKS Closes #283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Two processes calling
roll.Initsimultaneously have a chance of a deadlock:https://github.com/xataio/pgroll/blob/main/pkg/roll/roll.go#L88-L90
Advisory locking could be a solution here.
The text was updated successfully, but these errors were encountered: