Add rename_constraint operation to PgRollOperation JSON schema definition
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemmiillyy
approved these changes
Mar 1, 2024
SferaDev
approved these changes
Mar 1, 2024
andrew-farries
added a commit
that referenced
this pull request
Mar 4, 2024
Add a CI step to validate that the example migrations are valid according to the JSON schema. This would have caught the problem where the JSON schema was not fully updated in #293 and had to be updated in a follow-up PR #300 despite #293 including an example migration. Use [ajv-cli](https://ajv.js.org/packages/ajv-cli.html) to perform schema validation. Here is an [example run](https://github.com/xataio/pgroll/actions/runs/8113707179/job/22177613982) where the check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise migrations that include this operation are not valid according to the JSON schema.
Fixup to #293.