Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI step to validate examples against the JSON schema #301

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

andrew-farries
Copy link
Collaborator

Add a CI step to validate that the example migrations are valid according to the JSON schema.

This would have caught the problem where the JSON schema was not fully updated in #293 and had to be updated in a follow-up PR #300 despite #293 including an example migration.

Use ajv-cli to perform schema validation.

Here is an example run where the check fails.

Validate that the example migrations are valid according to the JSON
schema.
@andrew-farries andrew-farries changed the title Add validation step to build workflow Add CI step to validate examples against the JSON schema Mar 1, 2024
Copy link
Member

@SferaDev SferaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajv is great 🥳

@andrew-farries andrew-farries merged commit 63d5a7f into main Mar 4, 2024
42 checks passed
@andrew-farries andrew-farries deleted the validate-example-schema branch March 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants