Distinguish inferred migrations by timestamp for statements within the same transaction #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that two statements executed in a transaction have different timestamps in the migrations table.
When two statements are run in a transaction, we need to explicitly insert `statement_timestamp()` into the `created_at` and `updated_at` fields rather than relying on the table default of `current_timestamp`. `current_timestamp` is the same for all statements in a transaction, which causes problems when ordering statements by `created_at`.
andrew-farries
force-pushed
the
distinguish-inferred-migrations-by-timestamp
branch
from
da0a31e
to
053a0cf
Compare
exekias
approved these changes
Jun 25, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
created_atandupdated_atexplicitly when inserting inferred migrations into the migrations table.When two statements are run in a transaction, we need to explicitly insert
statement_timestamp()into thecreated_atandupdated_atfields rather than relying on the table default ofcurrent_timestamp.current_timestampis the same for all statements in a transaction, which causes problems when ordering statements bycreated_at.Fixes #361