Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAML Styler firing for Project files (*.csproj) also after updating to v3.2311.2. Previously, it was working fine. #448

Closed
egvijayanand opened this issue Nov 21, 2023 · 9 comments · Fixed by #453

Comments

@egvijayanand
Copy link

Describe the bug
XAML Styler firing for Project files (*.csproj) also after updating to v3.2311.2. Previously, it was working fine.

To Reproduce
Steps to reproduce the behavior:

  1. While saving the project file with the XML PI node, it throws an error
  2. Refer to the below screenshot for Error details:

Expected behavior
It should attempt to format only XAML files as the name suggests and optionally XML files with the xml extension.

Screenshots
image

External Configuration
NA

Version Info (please complete the following information):

  • OS: Windows 11 ver. 10.0.22631.2715
  • Visual Studio: VS2022 17.9 Preview 1.0
  • XAML Styler: v3.2311.2

Additional context
This started to occur after the recent update a few days ago.

@kmgallahan
Copy link

@grochocki Not critical, but this is fairly annoying.

@ghost1372
Copy link

i get this too

@Prodigio
Copy link

Prodigio commented Dec 13, 2023

Maybe a similair problem as this #278 issue?

@mrlacey
Copy link
Contributor

mrlacey commented Dec 22, 2023

I see this as a result of a change within VS (probably in 17.8) rather than relating to something changed in this extension.

@egvijayanand
Copy link
Author

I see this as a result of a change within VS (probably in 17.8) rather than relating to something changed in this extension.

Even then the extension is supposed to work accordingly. Rather it shows some weird dialog.

@mrlacey
Copy link
Contributor

mrlacey commented Dec 22, 2023

I see this as a result of a change within VS (probably in 17.8) rather than relating to something changed in this extension.

Even then the extension is supposed to work accordingly. Rather it shows some weird dialog.

I commented only to say that the assertion in the issue title may be misleading. Working on a fix now.

@ghost1372
Copy link

@grochocki can you publish a new version with this fixed issue?
This bug is very annoying

@grochocki
Copy link
Contributor

I am investigating an issue with the release build of the extension for VS2022 that is preventing it from loading properly, even though it seems to work find under debug. Will publish update as soon as I am able to resolve.

@grochocki
Copy link
Contributor

I am investigating an issue with the release build of the extension for VS2022 that is preventing it from loading properly, even though it seems to work find under debug. Will publish update as soon as I am able to resolve.

Tracking with #479.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants