Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resharper Template: Error in StylerPackage #278

Closed
Prodigio opened this issue May 6, 2020 · 12 comments
Closed

Resharper Template: Error in StylerPackage #278

Prodigio opened this issue May 6, 2020 · 12 comments
Labels

Comments

@Prodigio
Copy link

Prodigio commented May 6, 2020

Describe the bug
On hitting save, the XAML Styler tries to format the template from Resharper

To Reproduce
Steps to reproduce the behavior:

  1. Open the Template Explorer of Resharper
  2. Create a new template
  3. Write anything, doesn't matter.

Expected behavior
I do not expect the XAML Styler to check this.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Version Info (please complete the following information):

  • OS: Windows 10 Enterprise 2016 LTSB 64-bit (10.0, Build 14393)
  • Visual Studio: VS 2017 Version 15.9.22
  • XAML Styler: Version 3.2003.9
@Prodigio Prodigio added the Bug label May 6, 2020
@NicoVermeir
Copy link
Contributor

Thanks for reporting this!

looks like this only happens when a XAML based solution is opened, I can't reproduce it when I have an ASP.net project open for example, but I can with WPF project open. We'll investigate!

@MarkSandy
Copy link

Any news on this one?

@NicoVermeir
Copy link
Contributor

thanks for the ping @MarkSandy unfortunately no news on this.

@maartenba do you have an idea why ReSharper template editor would trigger XAML Styler?

@maartenba
Copy link
Contributor

Let me see if I can find anyone in the team who can shed some light on this...

@maartenba
Copy link
Contributor

Looks like XamlStyler will have to do some additional checks on the document that is open. Probably with the debugger attached, check if any of your checks (e.g. these https://github.com/Xavalon/XamlStyler/blob/master/src/XamlStyler.Extension.Windows/Extensions/DocumentExtensions.cs) should be extended with additional conditions based on Document properties.

@Prodigio
Copy link
Author

Prodigio commented Feb 24, 2022

I guess still no news on this?

I'm now running VS2022 and unfortunately I still epxerience it.

Just want to add, that even though the message box appears, the document itself get's saved. But it's annoying.

@Prodigio
Copy link
Author

Another thing I noticed: when saving all changes, not just per file, with shortcut CTRL + Shift + S the error does not appear.

@xEsteem
Copy link

xEsteem commented Sep 26, 2022

Very frustrating little bug here

@Prodigio
Copy link
Author

@maartenba could you help us out with a PR, after you nailed down the cause? Would really appreciate it!

@maartenba
Copy link
Contributor

#278 (comment) is what I was advised back then, not sure how though 😅

@Prodigio
Copy link
Author

Unfortunate. ;)

@Prodigio
Copy link
Author

Close, as it was solved by #453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants