-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline support #26
Pipeline support #26
Conversation
@ErlanBazarov @mpvosseller ok, i've got a proof-of-concept up! It's only the Unfortunately, I don't use heroku much these days and don't have any pipelines set up correctly to actually use this feature. So, I'd really appreciate a hand testing it. To install it:
Now when you run Alternatively, you could (temporarily) invite me to a sample pipeline that is already set up and I can test this out manually. Thanks for your help here! |
@xavdid Amazing! I'll try to check this out soon. FWIW setting up a pipeline to test this is trivial and can be done for free with an empty placeholder app and pipeline.
|
@xavdid I tested it out and
|
@mpvosseller awesome, great to hear! I'm not seeing that invite, in my heroku dashboard but it's probably ok! If it's working, I should be able to add the other pieces. |
Ok, that should do it! I can do some manual testing later, but the PR as written should push and pull using the exact same logic as before, but now targeting pipes instead. You're welcome to try the heroku invite again, or you can just test it yourself and I can release once you give the 👍 |
Ok, tests look good! Merging and deploying. |
Adds support for specifying a
--pipeline-name
and--pipeline-stage
instead of an--app
. Fixes #25.