Allow single component domains (such as localhost) to be recognized a…

…s OpenID identities.
xaviershay · Jul 23, 2011 · 4e42e43 · 4e42e43
1 parent 60ea50e
commit 4e42e43
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/app/models/comment.rb b/app/models/comment.rb
@@ -27,7 +27,9 @@ def blank_openid_fields
   end
 
   def requires_openid_authentication?
-    !!self.author.try(:index, '.')
+    return false unless author
+
+    !!(author =~ %r{^https?://} || author.index('.'))
   end
 
   def trusted_user?

diff --git a/spec/models/comment_spec.rb b/spec/models/comment_spec.rb
@@ -49,6 +49,13 @@ def set_comment_attributes(comment, extra = {})
     @comment.requires_openid_authentication?.should == true
   end
 
+  it "requires OpenID authentication when the author's name starts with http" do
+    @comment.author = "http://localhost:9294"
+    @comment.requires_openid_authentication?.should == true
+    @comment.author = "https://localhost:9294"
+    @comment.requires_openid_authentication?.should == true
+  end
+
   it "asks post to update it's comment counter after save" do
     set_comment_attributes(@comment)
     @comment.blank_openid_fields