Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to UNmatch and/or REmatch files to Scenes #141

Closed
vpfruitly opened this issue Oct 22, 2019 · 8 comments · Fixed by #570
Closed

Ability to UNmatch and/or REmatch files to Scenes #141

vpfruitly opened this issue Oct 22, 2019 · 8 comments · Fixed by #570
Labels
enhancement New feature or request

Comments

@vpfruitly
Copy link
Contributor

Unless I'm being super dense and missing something, if you assign a file to a scene incorrectly, there's no way to fix that. Being able to unmatch or change the match would both solve the problem.

Perhaps linking the scene match modal right from the details view for a matched scene, and another button to just unmatch it entirely (for if you matched a file that has no corresponding scraper, to return it to bare file status).

@cld9x
Copy link
Collaborator

cld9x commented Oct 22, 2019

Currently there's no way to remove scene assignment from file.

Unmatching only make sense if you could remove link from both "files" and "scene" navigation modes, so I think this should be implemented together in order to avoid confusion.

@jrebey
Copy link
Contributor

jrebey commented Oct 23, 2019

Files don't show up in the Files list once they are matched to a Scene so this would have to be done in the Scene navigation. We can probably reuse the modal (with an added Unmatch Scene button).

@jrebey jrebey added the enhancement New feature or request label Oct 23, 2019
This was referenced Oct 29, 2019
@jwvanderbeck
Copy link
Contributor

Just ran into this issue myself where I assigned the wrong match and only realized it after the fact. Now I guess its stuck that way?

@vpfruitly
Copy link
Contributor Author

Just ran into this issue myself where I assigned the wrong match and only realized it after the fact. Now I guess its stuck that way?

Make a small change in the filename of the mis-matched file, then rescan files. The old entry will be removed and you can manually match again.

@jwvanderbeck
Copy link
Contributor

Just ran into this issue myself where I assigned the wrong match and only realized it after the fact. Now I guess its stuck that way?

Make a small change in the filename of the mis-matched file, then rescan files. The old entry will be removed and you can manually match again.

Ahh nice trick I'll try that. It looks like the UI is almost setup to allow what we need here though. If you go to a scene you see the files linked to it. I for example had in some cases multiple files for the same scene because either I had downloaded it twice or had different resolutions. That UI does let me physically delete files from there which is handy. It really just needs an extra button for "unlink" or something.

@dnizmirc
Copy link

Instead of opening a new issue, figured I'd just comment here echoing desire for a way to fix match / unmatch / or remove an entry (Without deleting a file), some way in XBVR to fix a mistake (without having to move/rename files manually). It would be appreciated.

@theRealKLH
Copy link
Collaborator

you can "edit scene details" and delete the wrong filename/add the right one (or just do rescan) from there.
image

@theRealKLH
Copy link
Collaborator

@vpfruitly cleaning "dead" issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants