Merge pull request redhat-openstack#254 from juniorsysadmin/udlc-stratum

(MODULES-1837) Make udlc stratum configurable

README.markdown

@@ -265,6 +265,10 @@ Tells Puppet what NTP service to manage. Valid options: string. Default value: v
 
 Specifies whether to configure ntp to use the undisciplined local clock as a time source. Valid options: 'true' or 'false'. Default value: 'false'
 
+####`udlc_stratum`
+
+Specifies the stratum the server should operate at when using the undisciplined local clock as the time source. It is strongly suggested that this value be set to no less than 10 where ntpd may be accessible outside your immediate, controlled network. Default value: 10
+
 ##Limitations
 
 This module has been tested on [all PE-supported platforms](https://forge.puppetlabs.com/supported#compat-matrix), and no issues have been identified.

manifests/init.pp

@@ -28,6 +28,7 @@
   $service_manage    = $ntp::params::service_manage,
   $service_name      = $ntp::params::service_name,
   $udlc              = $ntp::params::udlc,
+  $udlc_stratum      = $ntp::params::udlc_stratum,
 ) inherits ntp::params {
 
   validate_bool($broadcastclient)

manifests/params.pp

@@ -15,6 +15,7 @@
   $service_ensure    = 'running'
   $service_manage    = true
   $udlc              = false
+  $udlc_stratum      = '10'
   $interfaces        = []
   $disable_auth      = false
   $broadcastclient   = false

spec/acceptance/ntp_parameters_spec.rb

@@ -181,4 +181,16 @@ class { 'ntp':
     end
   end
 
+  describe 'udlc_stratum' do
+    it 'sets the stratum value when using udlc' do
+      pp = "class { 'ntp': udlc => true, udlc_stratum => 10 }"
+      apply_manifest(pp, :catch_failures => true)
+    end
+
+    describe file("#{config}") do
+      it { should be_file }
+      its(:content) { should match 'stratum 10' }
+    end
+  end
+
 end

templates/ntp.conf.erb

@@ -42,7 +42,7 @@ server <%= server %><% if @iburst_enable == true -%> iburst<% end %><% if @prefe
 # Undisciplined Local Clock. This is a fake driver intended for backup
 # and when no outside source of synchronized time is available.
 server   127.127.1.0
-fudge    127.127.1.0 stratum 10
+fudge    127.127.1.0 stratum <%= @udlc_stratum %>
 restrict 127.127.1.0
 <% end -%>