Merge pull request #314 from amateo/feature/loadyaml_check_file

Check if file exists before loading with loadyaml. If not, return nil
xbezdick · Apr 16, 2015 · 8a1d1e2 · 8a1d1e2
2 parents 59b3fb4 + ac24e7a
commit 8a1d1e2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/puppet/parser/functions/loadyaml.rb b/lib/puppet/parser/functions/loadyaml.rb
@@ -13,7 +13,12 @@ module Puppet::Parser::Functions
       raise Puppet::ParseError, ("loadyaml(): wrong number of arguments (#{args.length}; must be 1)")
     end
 
-    YAML.load_file(args[0])
+    if File.exists?(args[0]) then
+      YAML.load_file(args[0])
+    else
+      warning("Can't load " + args[0] + ". File does not exist!")
+      nil
+    end
 
   end
 

diff --git a/spec/functions/loadyaml_spec.rb b/spec/functions/loadyaml_spec.rb
@@ -14,6 +14,12 @@
     expect { scope.function_loadyaml([]) }.to raise_error(Puppet::ParseError)
   end
 
+  it "should return nil when file does not exist" do
+    yaml_file = tmpfilename ('yamlfile')
+    result = scope.function_loadyaml([yaml_file])
+    expect(result).to(eq(nil))
+  end
+
   it "should convert YAML file to a data structure" do
     yaml_file = tmpfilename ('yamlfile')
     File.open(yaml_file, 'w') do |fh|