Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G17 Support / Default OrcaSlicer Profile #48

Closed
KaruroChori opened this issue Mar 11, 2024 · 7 comments
Closed

G17 Support / Default OrcaSlicer Profile #48

KaruroChori opened this issue Mar 11, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@KaruroChori
Copy link
Collaborator

KaruroChori commented Mar 11, 2024

It was discussed in a different post. It is a command not supported by klipper 0.11, only from 0.12 onward. It is used to handle a better type of z-hop mechanism.
Comparing the code in 0.12 and 0.11 for the relevant functionality it was my opinion that a patch was quite simple.
Otherwise the slicer profile should change the mode being used for z-hop.

Originally posted by @KaruroChori in #36 (comment)

I added few lines to comment this issue in the docs, so that it is not a problem for release.
Ideally, either we patch support for it in, or we ensure profiles do not use the spiral z-hop path.

@KaruroChori KaruroChori added the enhancement New feature or request label Mar 11, 2024
@consp
Copy link
Collaborator

consp commented Mar 11, 2024

I already tested it in my own version by patching klipper like you suggested before by updating the zhop code path from the mainline version. It works as far as I can tell.

@KaruroChori
Copy link
Collaborator Author

Great, I had no idea!

@consp
Copy link
Collaborator

consp commented Mar 11, 2024

Hasn't been merged yet ;) Just for testing and getting rid of the annoying messages.

I think we should discuss patches when the structure is more clear. Currently klipper is a submodule with already one patch applied. Maybe that's the way to go or we take a different approach. Preferably of course FF updates to klipper v12 so we can use mainline.

@consp consp reopened this Mar 11, 2024
@xblax
Copy link
Owner

xblax commented Mar 11, 2024

If we want this to be patched, we need the proper patches reflecting the upstream changes
We can consider this after #32

I want to move away from the forked repos such as Klipper/Buildroot and have everything integrated in the main repo. We can then maintain a set of patches to 0.11 with quilt. Or maybe Klipper could also become a Buildroot package instead of doing everything in post build, but haven't though enough about this yet.

About the warnings: Is this configured wrong in the default Orca Slicer profile for ADM5 as well? Since Klipper 0.11 doesn't support it I would assume it's disabled in the default profiles.

@KaruroChori
Copy link
Collaborator Author

KaruroChori commented Mar 11, 2024

@xblax from what I can recall yes. I started my configuration from the original flashforge profiles, but I cannot recall if they were shipped with my specific version of OrcaSlicer or if I had them downloaded from their website.

In theory G17 has no effect unless the plane was changed before with another command in the series, so even if it appears in the original firmware, they might not care.

@consp
Copy link
Collaborator

consp commented Mar 11, 2024

specific version of OrcaSlicer or if I had them downloaded from their website.

The 2.x.dev version which supports the flashforge network integration does it at least.

xblax pushed a commit that referenced this issue Apr 19, 2024
@KaruroChori
Copy link
Collaborator Author

This has been integrated in the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants