Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature req] pvr overview rework - not an issue #176

Closed
howie-f opened this issue Feb 18, 2021 · 8 comments · Fixed by #158
Closed

[feature req] pvr overview rework - not an issue #176

howie-f opened this issue Feb 18, 2021 · 8 comments · Fixed by #158

Comments

@howie-f
Copy link

howie-f commented Feb 18, 2021

in my naivety i'm saying that is not a big deal ;) though only a feature request.
can the pvr overview get a bit tuned, like it is faked here for recording no. 2 ? cheers

Unbenannt

@wutschel
Copy link
Collaborator

That will be quite easy to implement as "art" is already requested (and provided by Kodi) for recordings. Just need to ensure this is not impacting other thumbviews, and check if this works for timers as well. Looks like this after a 3-lines-of-code change:

@wutschel
Copy link
Collaborator

Implemented and added to #158.

@howie-f
Copy link
Author

howie-f commented Mar 20, 2021

thanks much for implementing this.
can we adjust it so the station logos for pvr recordings (left side) match in size for e.g. channel overview?

IMG_0113

@wutschel
Copy link
Collaborator

Let me look into this.

@wutschel
Copy link
Collaborator

It´s quite hard to adapt the recording thumb sizes to the current channel list thumb sizes properly. What is easy to achieve is to adapt both thumbs to a similar look. The logos are using the complete cell but with a frame for better readability.

https://abload.de/img/simulatorscreenshot-iq7jti.png
https://abload.de/img/simulatorscreenshot-i3dkes.png
https://abload.de/img/simulatorscreenshot-iz5jdq.png

@howie-f
Copy link
Author

howie-f commented Mar 21, 2021

It´s quite hard to adapt the recording thumb sizes to the current channel list thumb sizes properly.

sorry, didnt expect this 😏

@wutschel
Copy link
Collaborator

I find the solution from the PR visually also quite nice. But the PR is raised as draft, maybe I find a better solution. Problem is that the menu level (and logic) in the recordings view is different to the one in the channel list. With the straight forward solution of adding same sizes of the UIImageView I get side effects I do not understand yet. But of course there´s no need to hurry...

@wutschel
Copy link
Collaborator

wutschel commented Mar 21, 2021

Now I think I found a way. But I will ask kambala for some help on this. There is something I do not understand fully yet: To achieve this I need to stop using dequeueReusableCellWithIdentifier which I understood makes a performance impact.

Looks like this now:
https://abload.de/img/simulatorscreenshot-ig1k4h.png
https://abload.de/img/simulatorscreenshot-inyjn6.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants