Bugfix: Fix top padding

[wutschel]

Description

Fixes a regression caused by #889.

Generally it is correct to use UIApplication.sharedApplication.keyWindow.safeAreaInsets.top in getTopPadding. This resolves issues with moving and wrongly positioned tables in iPhone main menu and custom button view. For the HostManagementViewController we use UIApplication.sharedApplication.statusBarFrame.size.height to read the size of the status bar.

Summary for release notes

Bugfix: Fix vertical origin of main menu and custom button view

[wutschel]

Conflicts with #1004. Please prioritize #1004, I will then rebase this one.

[wutschel]

Converted back to draft as I obviously should relook the approach. It seems I need two different padding values: one when showing a navbar (= status bar height + navbar height) and another when not (= safe area height). For this I need to revisit the code as some views have a navbar and some have not.

[wutschel]

I am sure you will stumble over this one:

deltaY = 44 + UIApplication.sharedApplication.statusBarFrame.size.height;

The 44 is the NavigationBar's height which is 0 during init time. I am not sure why moving the messagesView layout to viewDidLoad does result in invisible messages, For now let us please keep it like this, I anyway have an issue open to rework the whole SettingsValuesVC which is the nastiest piece of code left from the past.

[kambala-decapitator]

it's very simple: in viewDidLoad views don't have their final size. The best place to perform layout is viewDidLayoutSubviews

[wutschel]

viewDidLayoutSubviews

Works. I am sure this is still done wrong in many places ... So much work to do ...

[wutschel]

Squashed and ready to go.