Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Rework several icon colors #1016

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

wutschel
Copy link
Contributor

@wutschel wutschel commented Mar 31, 2024

Description

Closes #1013.
Closes #1019.

Minor icon updates:

  • The icons used for folder, file, genre, movie genre, settings, person and and music/video/image use a dark blue color scheme. This PR removes their saturation and keeps brightness. This is equal to iOS' darkGrayColor.
  • The icons used by MoreItemsViewController (e.g. pressing "..." in the Music menu) now load dark and night mode colors to automatically adapt w/o reloading the icons.

Summary for release notes

Maintenance: Rework several icon colors

@wutschel wutschel force-pushed the rework_icon_colors branch 2 times, most recently from 27dbc9c to a62763d Compare April 2, 2024 17:29
@wutschel wutschel marked this pull request as ready for review April 2, 2024 17:30
Copy link
Collaborator

@kambala-decapitator kambala-decapitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflicts

@wutschel
Copy link
Contributor Author

wutschel commented Apr 2, 2024

Rebased and resolved conflict.

@kambala-decapitator kambala-decapitator merged commit 0aa3094 into xbmc:master Apr 3, 2024
@wutschel wutschel deleted the rework_icon_colors branch April 3, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants