Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainance: Refactor building iPad's play control toolbar #1025

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

wutschel
Copy link
Collaborator

@wutschel wutschel commented Apr 3, 2024

Description

Closes #1023.

Fixes a review comment about improving the code which generates iPad's play control toolbar.

Summary for release notes

Maintenance: Refactor building iPad's play control toolbar

@wutschel
Copy link
Collaborator Author

wutschel commented Apr 3, 2024

@kambala-decapitator, this is what you had in mind?

@wutschel wutschel marked this pull request as ready for review April 3, 2024 09:07
@kambala-decapitator
Copy link
Collaborator

@kambala-decapitator, this is what you had in mind?

basically yes, but with dictionary it'll be a bit simpler :)

@kambala-decapitator kambala-decapitator merged commit 1f733ba into xbmc:master Apr 4, 2024
@wutschel wutschel deleted the maintain_nowplaying branch April 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor iPad play control layout to use dictionary and loop
2 participants