Improvement: Global connection status for iPhone #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping this draft for now as there are still some points of discussion:
|
wutschel
force-pushed
the
feature_global_status
branch
2 times, most recently
from
30f3401
to
aa2f408
Compare
kambala-decapitator
approved these changes
Apr 21, 2024
Allows to use serverOnLine for checking the connection status instead of comparing the icon name. In addition remove obsolete declaration of method.
Introduces new ivar globalConnectionStatus which holds the image reflecting the current connection status. This image view is added to the root view to be always visible. The first row in main menu is now showing a Kodi icon instead of the traffic light status.
Aligns the code for iPad and iPhone. This cannot be further simplified as there are different specific actions need for iPad and iPhone caused by different UI elements.
wutschel
force-pushed
the
feature_global_status
branch
from
ff7d21f
to
dbd140d
Compare
|
Resolved first finding, squashed this and rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a globally visible connection status icon for iPhone. On iPad this was already visible in the right corner of the toolbar, on iPhone an upper left position on top of the navigation bar is chosen. With this change it is possible to recognize connection state without moving through the menus to a remote screen or the server list.
The status icon is not visible when entering the Kodi settings. I will not fix this as the code in this area will anyway change when the settings are moved to main menu.
Screenshots: https://ibb.co/g3CdX7c
Summary for release notes
Improvement: Global connection status for iPhone