Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Remove icons when browsing settings, genres and movie genres #1032

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

wutschel
Copy link
Collaborator

@wutschel wutschel commented Apr 5, 2024

Description

Closes #1014.

This PR modernizes the look when browsing settings, music and movie genres. Instead of a dummy icon there is no icon but UITableViewCellAccessoryDisclosureIndicator shown.

Screenshots:
https://ibb.co/RjGVmFY -> settings before
https://ibb.co/Tv0zVfs -> settings after

Summary for release notes

Improvement: Remove icons when browsing settings, genres and movie genres

@wutschel wutschel marked this pull request as ready for review April 6, 2024 20:25
Copy link
Collaborator

@kambala-decapitator kambala-decapitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not showing the indicator whenever there's a child view? That's quite a common pattern in iOS

@wutschel
Copy link
Collaborator Author

why not showing the indicator whenever there's a child view? That's quite a common pattern in iOS

Yes, it does behave like this with the exception of when cover/station/... thumbnails are shown. In this case the width of the label would be too small to show many of the item titles. I felt the value of longer labels higher than consistent use of indicators.

@kambala-decapitator kambala-decapitator merged commit d508cad into xbmc:master Apr 21, 2024
@wutschel wutschel deleted the remove_nocover_icons branch April 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove icons for genre, movie genre and settings in list view
2 participants