Maintenance: Remove detailView ivar from DetailViewController #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
remove_detailview_ivar
branch
from
3986cf7
to
43984ac
Compare
wutschel
force-pushed
the
remove_detailview_ivar
branch
from
43984ac
to
7122430
Compare
wutschel
force-pushed
the
remove_detailview_ivar
branch
from
7122430
to
b584baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
detailViewivar from DetailViewController and its related xib as it is not needed anymore. In addition it brings the dimensions back to the normally used 320x416. The view's dimension was off in the xib since 4 years.Summary for release notes
Maintenance: Remove detailView ivar from DetailViewController
Maintenance: Bring back DetailVC xib dimensions to normal