Feature: show watched flag for seasons #1062
Conversation
wutschel
force-pushed
the
feature_season_watched
branch
from
616c2bc
to
370c33c
Compare
XBMC Remote/DetailViewController.m
Outdated
| if (isWatched) { | ||
| UIImageView *watchedIcon = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"OverlayWatched"]]; | ||
| watchedIcon.frame = CGRectMake(CGRectGetMaxX(thumbImageView.frame) - FLAG_SIZE / 2 - TINY_PADDING, | ||
| CGRectGetMaxY(thumbImageView.frame) - FLAG_SIZE - TINY_PADDING, | ||
| CGRectGetWidth(watchedIcon.frame), | ||
| CGRectGetHeight(watchedIcon.frame)); | ||
| [albumDetailView addSubview:watchedIcon]; | ||
| } |
There was a problem hiding this comment.
I suspect that this would break in reused headers
There was a problem hiding this comment.
Add a fixup to always add the UIImageView and then hide/unhide. Is this what you had in mind?
There was a problem hiding this comment.
Yes, correct.
But I also see that other subviews are always created, although normally you'd create them once and then receive them from a reused cell / header / footer. Maybe their container is anyways re-created? That's not really good, but out of scope of this PR.
There was a problem hiding this comment.
True, I also saw this when reading your comment. I am not sure, if the headers are even reused. I can look into this at a later point in time.
There was a problem hiding this comment.
I saw it's called from viewForHeader, so it can be reused
There was a problem hiding this comment.
So we can make this more efficient by using dequeueing, but as it is not implement now we have no problem. Correct?
There was a problem hiding this comment.
yes, seems so
wutschel
force-pushed
the
feature_season_watched
branch
from
7d53e63
to
74ec411
Compare
|
Squashed and rebased. |
Description
This PR adds the possibility to show the watched flag for seasons in the so-called episodesView.
Screenshot: https://ibb.co/QHPYSnb
Summary for release notes
Feature: show watched flag for seasons