Improvement: Use transparent background for grid / collection view #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
improve_gridview_colors
branch
from
802dc69
to
b408718
Compare
Each of these is required to use the standard background for grid views.
We need to apply rounded edges PosterCell 's bottom label view to align with the underlying cover.
Make the selected background only visible for 1 pixel. In consequence use CGFloat for frame dimensions and adapt factors.
Keep using clear background.
wutschel
force-pushed
the
improve_gridview_colors
branch
from
b408718
to
2127eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The grid / collection view was using a darker background as the list views. This PR applies changes to let the grid/collection views have the standard application background by using transparent backgrounds where needed. For rounded corners this also required a change to the
PosterCellclass to let a label view follow the borders of the underlying cover. For recently added posters the blue "selected" highlighting is reduced to 1 pixel and the non-selected state simply uses clear background. This enlarges the covers/fanart visibly.Screenshots (left = old, right = new):
Summary for release notes
Improvement: Use transparent background for grid / collection view