Improvement: Rework AppInfoView to scale up size and remove unneeded gimmicks #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
changed the title
|
@kambala-decapitator, do I understand correct that the App's name in Appstore is always "Official Kodi Remote"? So there is no localization for different countries? If so, I should also remove the localization for the App's name in the AppInfoVC. |
yes, we have only US English text on ASC |
kambala-decapitator
approved these changes
Jun 13, 2024
- Remove speech ballon and translations for "enjoy!" - Remove translations for "Official Kodi Remote" - Remove "for iOS", this is obvious - Remove io and mask - Remove audio functionality - Remove unneeded button and credits scrollview
Increase label view size and related fonts to use larger display / popover sizes. Make version text use UIColor.labelColor and an increased font size.
|
Removed the changes to non-English-GB localization files, this is done by weblate. The squashed and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small set of changes to the AppInfoView:
UIColor.labelColorand an increased font size.Screenshots (left pair iPhone 14 Pro, right pair iPod Touch 7G)
Summary for release notes
Improvement: Rework AppInfoView to scale up size and remove unneeded gimmicks