Improvement: IPv4, IPv6 and host name can be changed after calling Find Kodi once #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kambala-decapitator, I am making this draft as it would be good, if you can test this. I don't want to mess this up right before the release. |
wutschel
force-pushed
the
improve_findkodi
branch
from
6602acb
to
8cfe336
Compare
kambala-decapitator
approved these changes
Jun 13, 2024
- Fill server name, address, http port and tcp port only once - Let server data follow selection of ipv4, ipv6 or host name
Introduce helpers to fill select and show the server details for the selected segment.
Embed the whole processing in a condition. Remove the fallback logic as this is not required anymore.
- Increase width for address - Decrease width and font size for ports - Do not scale font size for ports and MAC address - Use thin light gray border
wutschel
force-pushed
the
improve_findkodi
branch
from
8cfe336
to
404a4b8
Compare
Thanks, fixed this as well. |
|
Reworked, squashed and rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested by @kambala-decapitator.
"Find Kodi" now only needs to be called once. This is will execute the service discovery for all supported address types. Afterwards the user can select the address type without running "Find Kodi" again.
Important: MAC address can only be resolved using iPv4. The code has been changed to use only IPv4 for this, even if the user selects IPv6 or host name as address type. If IPv4 address cannot be found, the MAC address cannot be resolved.
Summary for release notes
Improvement: IPv4, IPv6 and host name can be selected after calling Find Kodi once