Bugfix: Recording details and failed attempts to load images #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
fix_radio_rec
branch
from
e2fbd5a
to
b68cd21
Compare
kambala-decapitator
requested changes
Sep 18, 2021
kambala-decapitator
requested changes
Sep 18, 2021
kambala-decapitator
approved these changes
Sep 18, 2021
- TV station paths start with "pvr:". This can be used to determine the App shows a TV station logo.
Move duplicated code into helper function.
wutschel
force-pushed
the
fix_radio_rec
branch
from
e7da1e9
to
207d3d9
Compare
|
Rebased to master and squashed the fixups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides several bugfixes and minor refactoring:
Recording details shall not show jewel cases. This is consistent with the TV logo in the list views
Fix automatic background color for TV logos in recording details (regression of rounded corners feature)
Provide default images on a failed load attempt (verified with non-existing TV logo images and empty thumbnail paths)
Fix automatic background color for TV logos in Favourites menu
Simplify conditions and correct indentations in ShowInfoVC, move variable declarations near their usage
Summary for release notes
Bugfix: Recording details shall not show jewel cases
Bugfix: Fix automatic TV logo background for recording details and in Favourites menu
Bugfix: Provide default image on failing attempt to load image