Feature: Split TV/Radio into separate main menus

[wutschel]

Description

Closes #221.

Current Kodi server (v19) splits PVR into "TV" and "Radio" main menus. With this PR the Remote App now follows this principle as well. When entering TV or Radio menu, the full channel list is shown as default. In addition, it is possible to navigate through the channel groups, recordings and timers as before.

Menu structure (example based on Live TV): https://abload.de/img/bildschirmfoto2021-09a2kze.png

Summary for release notes

Feature: Split TV/Radio into separate main menus

[kambala-decapitator]

I skipped commits dd009c9, efb5421 and 6b6d38f.

With this change Kodi < 19 still behaves as before?

[wutschel]

With this change Kodi < 19 still behaves as before?

Valid question. The Split into Radio and TV is done for all versions. Thanks you asked and made me recheck as I now found an issue with adding the radio key to PVR.GetRecordings. This fails with Kodi 15 (JSON RPC v6), it needs to be removed in this case. This will result in showing all recordings in both TV and Radio submenu -- like it is done in the Kodi 15 UI as well. This is a bit unpleasant as PVR.GetRecording is working, but not even documented for JSON RPC v6. For any version before v6 there are no PVR methods documented and I expect that the Remote App always would try to request PVR, and always did.

Well, I cannot boil the ocean and will look at a more robust way to handle this for RPC v6 and higher.

[wutschel]

Update see below.

[wutschel]

Rebased to master.

[wutschel]

Tested with a lot of old versions (11, 12.3, 13.2, 14.2, 15.2, 16.1, 17.6, 18.4 and 19.1) and worked out the handling of PVR commands:

1. xbmc 11: no PVR support at all
2. xbmc 12: PVR support without recordings and timers
3. xbmc 13 - kodi 16: PVR support with recordings (Radio/TV not seperated) and timers (Radio/TV seperated)
4. Kodi 17: All recordings reported as "TV", timers have correct separate Radio/TV results
5. Kodi 18: Recordings have correct separate Radio/TV results, all timers reported as "TV"
6. Kodi 19 ff: Full API support (incl. "sort"), correct and separate handling of Radio + TV for recordings

It is a bit frustrating to see such inconsistent behaviour. I cannot rely solely on the API supporting a request, and the behaviour might even depend on the PVR add-on. I now decided to configure the feature as follows:

• xbmc 11: no support for PVR at all, just showing empty results
• xbmc 12: PVR support for separate channel lists and channel groups. No support for recordings and timers.
• xbmc 13 - Kodi 18: PVR support for separate channel lists and channel groups. Common recordings and timers.
• Kodi 19 ff: PVR support for separate channel lists, channel groups, recordings and timers.

As a result the Remote App supports TV and Radio separate channel lists and channel groups from xbmc 12 on. The behaviour for recordings and timers is the same as before (always showing the aggregated lists including both Radio and TV items) until Kodi 19. Only with Kodi 19 you get the full experience also showing filtered results for recordings and timers. At least this PR still gives a more direct access to Radio and TV channels instead of being required to do multiple clicks to get there.

[wutschel]

@kambala-decapitator, if you are generally fine with the code I will squash where possible and mark it as ready-for-review to allow merging it. I see no other way getting further test depth than to bring this to TF. Right after this one we can add the Video menu PR. It is partly building on top of this, but will need some rebasing.

[kambala-decapitator]

I agree with the approach and apart from minor requested changes looks good.

[wutschel]

I agree with the approach and apart from minor requested changes looks good.

Ok. I just submitted the fixups and will later today do the squashing and rebasing.

[wutschel]

Squashed and rebased to master.