Rework section header layout for albums and episodes #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshots: |
kambala-decapitator
approved these changes
Jan 20, 2024
- Move duplicate code into helper method - Unify layout for albums and seasons - Correct and ease up the layout calculation - Simple runtime calculation and display - Replace magic numbers
Kodi uses 2:3 as aspect ratio for TV Show posters.
wutschel
force-pushed
the
rework_sectionheader
branch
from
0ad16af
to
4aa3473
Compare
|
Squashed and rebased to master. Let me know if there's anything else to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the layout of the section header for albums and episodes. Now both use the same layout and method instead of separate implementations.
Overview of changes:
Summary for release notes
Improvement: Rework section header layout for albums and episodes