Improvement: Reformat non-embedded to embedded youtube video link

[wutschel]

Description

The implemented solution will identify multiple variants of youtube.com and youtu.be links (http, https, www or not), extract the video id and create a fresh FullHD embedded youtube link from this. This allows to show all such links with in-app preview.

Summary for release notes

Improvement: Reformat non-embedded to embedded youtube video link

[kambala-decapitator]

in general looks good now, but I'd suggest also to do the following:

• use NSURL as ivar instead of NSString: you always create NSURL to pass to NSURLComponents, and in the end you need NSURL to create request anyway
• create NSURL and NSURLComponents outside of the new functions (i.e. do it in processTrailerFromString) and pass them to the functions

[wutschel]

in general looks good now, but I'd suggest also to do the following:

• use NSURL as ivar instead of NSString: you always create NSURL to pass to NSURLComponents, and in the end you need NSURL to create request anyway
• create NSURL and NSURLComponents outside of the new functions (i.e. do it in processTrailerFromString) and pass them to the functions

Good point, done.

[wutschel]

Squashed and rebased as I understood despite the comments it was approved. Just let me know, if you still would like me to do further changes.

[kambala-decapitator]

create NSURL and NSURLComponents outside of the new functions

seems you missed this point, could you adjust?

[wutschel]

seems you missed this point, could you adjust?

Yep, sorry. Was only focusing the NSURL part of it. Done now as well, out of consistency for all the link check methods.

[wutschel]

Squashed and rebased, with latest fixups. More rework than expected for this initially small change, but the implementation is more straight forward now.