Maintenance: Rework layout of progress pie and recording dot #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
rework_progresspie
branch
from
d3747af
to
1db01c6
Compare
|
Let me now rebase this one. |
should I wait with merging #974? |
No, you can move ahead. |
This also removes another magic number.
Introduce a define for the time label height. Place the progress pie in the middle of the residual vertical free space below the time label.
wutschel
force-pushed
the
rework_progresspie
branch
from
1db01c6
to
9695709
Compare
|
Ok, there is still something (slightly but visibly) off with the vertical center of the recording icon. But this PR does not change the layout, this is already present in the code on master. Let's move ahead with reviewing. |
kambala-decapitator
approved these changes
Feb 3, 2024
|
I will have it in 1 hour. |
This avoids code duplication when creating and adding subviews for the progress pie and the related timer icon.
wutschel
force-pushed
the
rework_progresspie
branch
from
9695709
to
0904a5b
Compare
|
Added (and squashed) a small fix which places the center of the recording icon correctly above the progress pie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes further magic numbers, slightly changes the layout itself and reduces code duplication by introducing a helper method as suggested in earlier reviews. It needs to be updated once #974 is merged.
Summary for release notes
Maintenance: Rework layout of progress pie and recording dot