Improvement: Avoid potential crashes and coding style #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kambala-decapitator
approved these changes
Feb 3, 2024
This is in line with using long for database IDs and avoids potential crashes when using channelid in further method calls.
Add array boundary check when showing cast. Chose better variable name for the NSArray which holds the cast. Do not need to use stringWithFormat for role and can drop check for length.
|
Changed as per discussion, squashed and rebased to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stringWithFormatwhere not neededSummary for release notes
Improvement: Avoid potential crashes and coding style