Maintenance: Refactor parts of DetailViewController #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kambala-decapitator
requested changes
Feb 9, 2024
wutschel
force-pushed
the
refactor_detailvc
branch
from
f8b776e
to
e5ec002
Compare
kambala-decapitator
approved these changes
Feb 19, 2024
wutschel
force-pushed
the
refactor_detailvc
branch
2 times, most recently
from
96feae8
to
b16383e
Compare
kambala-decapitator
approved these changes
Feb 21, 2024
Use two dedicated gesture recognizers for both list and grid view, load and add them in viewDidLoad.
Use same approach as for DetailVC.
wutschel
force-pushed
the
refactor_detailvc
branch
from
36bf8da
to
7b3bc43
Compare
|
Squashed and rebased to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a set of maintenance changes:
selectedIndexPathinstead of misnamed global variableselectedhandleLongPressSortButtonhandleLongPressSummary for release notes
Maintenance: Refactor parts of DetailViewController