Feature: Show tagline in movie details #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not for 1.14, so made it draft for now. |
|
Made this "ready for review" after we now released 1.14 and can bring in changes. |
wutschel
force-pushed
the
feature_tagline
branch
from
a9fc8de
to
4eaddfd
Compare
|
Converted to draft as this conflicts with #1004, which needs priority. |
wutschel
force-pushed
the
feature_tagline
branch
3 times, most recently
from
99d7352
to
3721179
Compare
Programmatical layout instead of using xib for most labels. This gives more flexibility to add or remove more labels, if needed.
wutschel
force-pushed
the
feature_tagline
branch
from
3721179
to
8407696
Compare
|
Rebased to master, resolved conflict and ready-for-review. |
kambala-decapitator
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the tagline to the movie details screen. This works for all ways to enter movie details in the movie menu (movies, genres, movies sets, recently added, playlists).
Screenshot: https://ibb.co/XWHP4wt
Summary for release notes
Feature: Show tagline in movie details