Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore the log files when they are generated #236

Closed
wants to merge 3 commits into from
Closed

Ignore the log files when they are generated #236

wants to merge 3 commits into from

Commits on May 7, 2020

  1. Ignore the log files when they are generated 

    Create two functions in the common module to get the full path of the
log files (debug log and reporter log) anywhere in the script. It will
avoid duplicate reference to the names of the log files.
Then whitelist the log file(s) generated to avoid reporting warnings.
Note that log files generated from another run will still be reported.
    @thombet
    thombet committed May 7, 2020
    Configuration menu
    Copy the full SHA
    1b7cd56 View commit details
    Browse the repository at this point in the history

  2. Create new test cases to validate the new feature 

    Fix the existing tests by adding the arguments "reporter" and
"enable_debug_log" in the stub of argparser (Args()).
Create new test cases to validate the log files are correctly ignored
or reported.

Also improve a bit the code in check_file_whitelist: check if the
file needs to be ignored at the very beginning of the loop since the
the other check (using regex) requires more lines to be executed.
    @thombet
    thombet committed May 7, 2020
    Configuration menu
    Copy the full SHA
    2a16084 View commit details
    Browse the repository at this point in the history

  3. Fix pylint errors

    @thombet
    thombet committed May 7, 2020
    Configuration menu
    Copy the full SHA
    9c52179 View commit details
    Browse the repository at this point in the history